Ticket 6637 - The collective type selection logic in the PMIx plugin
Summary: The collective type selection logic in the PMIx plugin
Status: RESOLVED FIXED
Alias: None
Product: Slurm
Classification: Unclassified
Component: PMIx (show other tickets)
Version: 19.05.x
Hardware: Linux Linux
: C - Contributions
Assignee: Tim Wickberg
QA Contact:
URL:
Depends on:
Blocks:
 
Reported: 2019-03-04 22:01 MST by Boris Karasev
Modified: 2019-04-29 14:03 MDT (History)
2 users (show)

See Also:
Site: -Other-
Slinky Site: ---
Alineos Sites: ---
Atos/Eviden Sites: ---
Confidential Site: ---
Coreweave sites: ---
Cray Sites: ---
DS9 clusters: ---
Google sites: ---
HPCnow Sites: ---
HPE Sites: ---
IBM Sites: ---
NOAA SIte: ---
NoveTech Sites: ---
Nvidia HWinf-CS Sites: ---
OCF Sites: ---
Recursion Pharma Sites: ---
SFW Sites: ---
SNIC sites: ---
Tzag Elita Sites: ---
Linux Distro: ---
Machine Name:
CLE Version:
Version Fixed: 19.05.0rc1
Target Release: ---
DevPrio: ---
Emory-Cloud Sites: ---

Attachments
0001-mpi-pmix-select-the-Tree-based-collective-type-for-e.patch (1.72 KB, patch)
2019-03-04 22:01 MST, Boris Karasev 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this ticket.
Description Boris Karasev 2019-03-04 22:01:05 MST 
Created attachment 9430 [details]
0001-mpi-pmix-select-the-Tree-based-collective-type-for-e.patch

Hello,

This patch changes the logic of selecting a type of collective. The Tree-based algorithm will be selected when fence with an empty data contribution, which allows for improved fence performance. In the other case, the ring type coll will be used.
Comment 2 Tim Wickberg 2019-04-29 14:03:26 MDT 
Hi Boris -

Thank you for the patch. This is in ahead of 19.05rc1 which will come out on Tuesday.

- Tim

commit fa5620dfd76760794d54f1be0395bf4da69339aa (HEAD -> master)
Author:     Boris Karasev <karasev.b@gmail.com>
AuthorDate: Mon Mar 4 15:14:43 2019 +0600

    mpi/pmix: use the Tree-based collective type for empty fence data.
    
    This commit changes the logic of selecting a type of collective. The
    Tree-based algorithm will be selected when fence with an empty data
    contribution, which allows for improved fence performance.
    
    Bug 6637.