as_mysql_convert.c:1028]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses. Source code is if ((rc = _convert_job_table_pre(mysql_conn, cluster_name) != SLURM_SUCCESS)) maybe better code if ((rc = _convert_job_table_pre(mysql_conn, cluster_name)) != SLURM_SUCCESS) Duplicates: [as_mysql_convert.c:1058]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses. as_mysql_convert.c:1064]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses. as_mysql_convert.c:1070]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses. as_mysql_convert.c:1076]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses. as_mysql_convert.c:1082]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses. as_mysql_convert.c:1107]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses. as_mysql_wckey.c:626]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses .eio.c:269]: (style) Suspicious con dition (assignment + comparison); Clarify expression with parentheses. log.c:251]: (style) Suspicious con dition (assignment + comparison); Clarify expression with parentheses.
Hi David - If you want to propose a patch to address these, I'm happy to review that as a contribution. I haven't seen these specific warnings in the static analysis tool we're using - do you mind sharing which tool is generating those warnings?
(In reply to Tim Wickberg from comment #1) > I haven't seen these specific warnings in the static analysis tool we're > using - do you mind sharing which tool is generating those warnings? cppcheck, available from sourceforge. I use it for all C/C++ development work.
