Ticket 4805 - FreeBSD build error, no roken.h file
Summary: FreeBSD build error, no roken.h file
Status: RESOLVED FIXED
Alias: None
Product: Slurm
Classification: Unclassified
Component: Build System and Packaging (show other tickets)
Version: 17.11.3
Hardware: Linux Linux
: 4 - Minor Issue
Assignee: Tim Wickberg
QA Contact:
URL:
Depends on:
Blocks:
 
Reported: 2018-02-19 11:12 MST by Moe Jette
Modified: 2018-02-27 08:20 MST (History)
1 user (show)

See Also:
Site: SchedMD
Slinky Site: ---
Alineos Sites: ---
Atos/Eviden Sites: ---
Confidential Site: ---
Coreweave sites: ---
Cray Sites: ---
DS9 clusters: ---
Google sites: ---
HPCnow Sites: ---
HPE Sites: ---
IBM Sites: ---
NOAA SIte: ---
NoveTech Sites: ---
Nvidia HWinf-CS Sites: ---
OCF Sites: ---
Recursion Pharma Sites: ---
SFW Sites: ---
SNIC sites: ---
Tzag Elita Sites: ---
Linux Distro: ---
Machine Name:
CLE Version:
Version Fixed: 17.11.4 18.08.0-pre2
Target Release: ---
DevPrio: ---
Emory-Cloud Sites: ---

Attachments
Do not include rtoken.h on FreeBSD (1.46 KB, patch)
2018-02-27 08:19 MST, Joseph Mingrone 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this ticket.
Description Moe Jette 2018-02-19 11:12:47 MST 
A bug report was submitted for the FreeBSD slurm package claiming that the roken.h header is not needed and causes problems when WITHOUT_KERBEROS is used.  After a bit of grepping I do not see why it is required.  What do you say?  Should '#include <roken.h>' be dropped from src/plugins/mpi/pmi2/agent.c, src/plugins/mpi/pmi2/agent.c, and src/plugins/mpi/pmi2/pmi2.c?

Joseph Mingrone <jrm@ftfl.ca>
Comment 4 Tim Wickberg 2018-02-27 08:16:45 MST 
Joseph - 

I added you on as CC so you'd see this. I push this fix to strip those headers out, it doesn't look like they've been required for quite some time now:

commit c6330552bfddf924cd0b466dbd014dfb566b71fb
Author: Tim Wickberg <tim@schedmd.com>
Date:   Tue Feb 27 08:13:50 2018 -0700

    Remove <roken.h> header include from FreeBSD builds.
    
    No longer needed, and will cause errors on FreeBSD systems
    build with WITHOUT_KERBEROS.
    
    Bug 4805.
Comment 5 Joseph Mingrone 2018-02-27 08:19:40 MST 
Created attachment 6241 [details]
Do not include rtoken.h on FreeBSD
Comment 6 Joseph Mingrone 2018-02-27 08:20:58 MST 
Hi Tim.

The FreeBSD port/package has been running with the attached patch for about a week and so far, I have not received any reports.

Thanks,

Joseph