Ticket 386 - IPMI plugin: error in math
Summary: IPMI plugin: error in math
Status: RESOLVED FIXED
Alias: None
Product: Slurm
Classification: Unclassified
Component: Accounting (show other tickets)
Version: 2.6.x
Hardware: Linux Linux
: 3 - Medium Impact
Assignee: Danny Auble
QA Contact:
URL:
Depends on:
Blocks:
 
Reported: 2013-07-28 23:52 MDT by Thomas Cadeau
Modified: 2013-07-30 09:16 MDT (History)
0 users

See Also:
Site: Atos/Eviden Sites
Slinky Site: ---
Alineos Sites: ---
Atos/Eviden Sites: ---
Confidential Site: ---
Coreweave sites: ---
Cray Sites: ---
DS9 clusters: ---
Google sites: ---
HPCnow Sites: ---
HPE Sites: ---
IBM Sites: ---
NOAA SIte: ---
NoveTech Sites: ---
Nvidia HWinf-CS Sites: ---
OCF Sites: ---
Recursion Pharma Sites: ---
SFW Sites: ---
SNIC sites: ---
Tzag Elita Sites: ---
Linux Distro: ---
Machine Name:
CLE Version:
Version Fixed:
Target Release: ---
DevPrio: ---
Emory-Cloud Sites: ---

Attachments
patch for correct maths in IPMI plugin (1.66 KB, patch)
2013-07-28 23:52 MDT, Thomas Cadeau 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this ticket.
Description Thomas Cadeau 2013-07-28 23:52:07 MDT 
Created attachment 360 [details]
patch for correct maths in IPMI plugin

There is a bug in the code that leads to a wrong calculation of dE(n)
dE(n) = (t(n+1)-t(n)) * (w(n-1) + w(n)) / 2
instead of 
dE(n) = (t(n+1)-t(n)) * (w(n) + w(n+1)) / 2

the patch change this.

Thomas
Comment 1 Danny Auble 2013-07-30 09:16:17 MDT 
Good Catch!  This will be in the next 2.6 (commit b950ad0f63683ae5e6afbb46e06c29528c89e406).  Please check for +80 char lines.

Thanks,