Ticket 304 - return real cpu frequency instead of weighted frequency
Summary: return real cpu frequency instead of weighted frequency
Status: RESOLVED CANNOTREPRODUCE
Alias: None
Product: Slurm
Classification: Unclassified
Component: Other (show other tickets)
Version: 2.6.x
Hardware: Linux Linux
: 5 - Enhancement
Assignee: Moe Jette
QA Contact:
URL:
Depends on:
Blocks:
 
Reported: 2013-05-27 02:41 MDT by Yiannis Georgiou
Modified: 2014-04-14 09:17 MDT (History)
2 users (show)

See Also:
Site: Atos/Eviden Sites
Slinky Site: ---
Alineos Sites: ---
Atos/Eviden Sites: ---
Confidential Site: ---
Coreweave sites: ---
Cray Sites: ---
DS9 clusters: ---
Google sites: ---
HPCnow Sites: ---
HPE Sites: ---
IBM Sites: ---
NOAA SIte: ---
NoveTech Sites: ---
Nvidia HWinf-CS Sites: ---
OCF Sites: ---
Recursion Pharma Sites: ---
SFW Sites: ---
SNIC sites: ---
Tzag Elita Sites: ---
Linux Distro: ---
Machine Name:
CLE Version:
Version Fixed:
Target Release: ---
DevPrio: ---
Emory-Cloud Sites: ---

Attachments
real cpu frequency instead of weighted frequency (1.90 KB, patch)
2013-05-27 02:41 MDT, Yiannis Georgiou 		Details | Diff
same patch, but for v14.11 (1.58 KB, patch)
2014-04-14 09:15 MDT, Moe Jette 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this ticket.
Description Yiannis Georgiou 2013-05-27 02:41:06 MDT 
Created attachment 256 [details]
real cpu frequency instead of weighted frequency
Comment 1 Danny Auble 2013-05-27 02:59:48 MDT 
I haven't looked much at this, but is this really what you want?  Is current_weighted_freq even used in the structure if this is applied?
Comment 2 Moe Jette 2013-08-07 08:06:30 MDT 
The current_weighted_freq variable remains in use, but only in the jobacct_gather_cgroup.c module. In fact, the logic in jobacct_gather_cgroup.c closely resembles that of jobacct_gather_linux.c (without this patch). So perhaps both files should be changed. I'm going to copy Martin on this bug to see if he cares to comment.
Comment 3 Martin Perry 2013-08-08 04:43:36 MDT 
I'm not sure why Yiannis suggested this change. I'll ask him about it. He's on vacation until August 19, so I probably won't get a reply before then. I agree that jobacct_gather_linux.c and jobacct_gather_cgroup.c should probably work the same way.
Comment 4 Moe Jette 2014-03-26 09:45:35 MDT 
Yiannis, Could you comment on this?
Comment 5 Moe Jette 2014-04-08 05:55:42 MDT 
Yiannis, Could you comment on this?
Comment 6 Moe Jette 2014-04-14 09:15:46 MDT 
Created attachment 758 [details]
same patch, but for v14.11

This is teh same logic as in Yiannis' patch, but updated for verion 14.11 (or 14.03).
Comment 7 Moe Jette 2014-04-14 09:17:22 MDT 
In reviewing this code, it appears the original logic is probably doing what we want. If you care to explain why this should change and re-open the ticket that's fine, but for now I am closing this.