Ticket 21725 - restd sbatch jobs: Create tests to validate job limits flags
Summary: restd sbatch jobs: Create tests to validate job limits flags
Status: OPEN
Alias: None
Product: Slurm
Classification: Unclassified
Component: Test Suite (show other tickets)
Version: 24.11.0
Hardware: Linux Linux
: 4 - Minor Issue
Assignee: Enrique Henderson
QA Contact:
URL:
Depends on:
Blocks:
 
Reported: 2024-12-30 09:07 MST by Enrique Henderson
Modified: 2025-02-14 09:50 MST (History)
0 users

See Also:
Site: SchedMD-Consultant
Alineos Sites: ---
Atos/Eviden Sites: ---
Confidential Site: ---
Coreweave sites: ---
Cray Sites: ---
DS9 clusters: ---
HPCnow Sites: ---
HPE Sites: ---
IBM Sites: ---
NOAA SIte: ---
NoveTech Sites: ---
Nvidia HWinf-CS Sites: ---
OCF Sites: ---
Recursion Pharma Sites: ---
SFW Sites: ---
SNIC sites: ---
Tzag Elita Sites: ---
Linux Distro: ---
Machine Name:
CLE Version:
Version Fixed:
Target Release: ---
DevPrio: ---
Emory-Cloud Sites: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this ticket.
Description Enrique Henderson 2024-12-30 09:07:27 MST 
This group of tests will validate job limits like time, nodes and resevation
Comment 1 Enrique Henderson 2025-02-12 07:31:03 MST 
This ticket includes the work to validate the submit_job options

Phase one: Include Associations
- test_validate_acctg_freq_with_associations
- test_validate_array_job_and_task_id
- test_validate_batch_flag_and_batch_host_options
- test_validate_cpu_frequency_cpus_per_tres_deadline
- test_validate_batch_features

Phase two: Initial Fixtures 
- reset_node_state
- custom_qos
- create_node

Phase three: 
- create_account
- create_user
- create_association
- create_job
- test_create_admin_user
- test_create_regular_user
- test_create_user
- test_create_user_with_all_parameters
- test_validate_job_allocation_and_timing
- test_create_regular_account
test_create_account_with_coordinators
test_validate_reserve_parameter
Comment 2 Enrique Henderson 2025-02-12 07:34:42 MST 
(In reply to Enrique Henderson from comment #1)
> This ticket includes the work to validate the submit_job options
> 
> Phase one: Include Associations
> - test_validate_acctg_freq_with_associations
> - test_validate_array_job_and_task_id
> - test_validate_batch_flag_and_batch_host_options
> - test_validate_cpu_frequency_cpus_per_tres_deadline
> - test_validate_batch_features
> 
> Phase two: Initial Fixtures 
> - reset_node_state
> - custom_qos
> - create_node
> 
> Phase three: Fixtures that setup the structures to process a job (currently create job is a fixture but will be a normal function)
> - create_account
> - create_user
> - create_association
> - create_job
> - test_create_admin_user
> - test_create_regular_user
> - test_create_user
> - test_create_user_with_all_parameters
> - test_validate_job_allocation_and_timing
> - test_create_regular_account
> - test_create_account_with_coordinators
> - test_validate_reserve_parameter
Comment 3 Enrique Henderson 2025-02-14 09:50:41 MST 
albert.gil@schedmd.com


Added initial offering of dynamic fixtures and tests that validate submit job options. I've included NOTES where there are questions or possible issues.  

I pushed to the testsuite_t21725 branch

To gitlab.com:SchedMD/dev/slurm.git
   365a34944e..5ee55eccf3  testsuite_t21725 -> testsuite_t21725

Please review: 

tests:
- test_resource_qos_time_limits
- test_submit_job_with_name_account_partition 
-- NOTE Currently the account stores the root account
- test_enforce_usage_threshold
- test_enforce_usage_threshold_and_deny_on_limit
- test_setting_accruing_count_limit
- test_validate_jobs_count_limit
- test_validate_active_jobs_per_account_limit
- test_validate_tres_per_node_limit
-- NOTE Currently if I add the node_name the node is not processed
- test_validate_acctg_freq_with_associations
- test_validate_array_job_and_task_id
- test_validate_array_task_id
- test_validate_batch_flag_and_batch_host_options
- test_validate_burst_buffer_and_fields

fixtures:

- Fixture: reset_node_state 
-- test_reset_node_state
--- NOTE This test was designed to remove the features as a reset but when we validate the removal both features are still in place.

- Fixture: custom_qos 
-- test_custom_qos

- Fixture: create_node
-- test_create_node

- Fixture: create_account
-- test_create_regular_account

- Fixture: create_user
-- test_create_admin_user
-- test_create_regular_user
-- test_create_operator_user
-- test_create_user_with_wckey
-- test_create_user_with_all_parameters

- Fixture: create_association
- Fixture: create_job (soon to be replaced with function)

-- Tests that use multiple fixtures:
- test_validate_cpu_frequency_cpus_per_tres_deadline
- test_validate_job_allocation_and_timing
- test_create_account_with_coordinators