Created attachment 2367 [details] Systemd/spec file changes We've started using systemd with slurm in RHEL7 but to do it neatly we had to tweak a few things. We also have a few other spec file changes that you may want to consider: Spec file changes: - best to use %{version} in Source and %setup (not that -n %{version} is necessary at all for %setup, not the way you have it) - various rpm subrpms should match version-wise - best to specify various dependencies - of course this is specific to rhel6/7 - not sure how many use this spec file on Suse, there is sure to be different. Without this it doesn't build in mock. - rpm should own support dirs (/var/spool/slurmd and friends) - logrotate support - where did useradd/group go for slurm? we sure want it Systemd: - we like having /etc/sysconfig options, just in case - it is best to let systemd know how to reload appropriate daemon (so systemctl reload slurmd/systemctl/... works) - spec file should install only systemd files on rhel7 and treat them accordingly - similarly systemd aware support for logrotate - we also like lifting default limits for slurmd, though not entirely sure that is required.
This would be great. I haven't looked at all the details of this patch, but we do similar things for the systemd files, logrotate, and limits.
Hi, the patch does not apply against latest 15.08.3 I tried older version but have the same problem: $ git apply --check slurm-systemdtweaks.patch error: patch failed: etc/slurmd.service.in:5 error: etc/slurmd.service.in: patch does not apply error: patch failed: slurm.spec:93 error: slurm.spec: patch does not apply could you regenerate the diffs against the latest commit 55c4de24e17a91ec249ba43? Thanks, David
Created attachment 2390 [details] Updated patch for 15.08.03
Thanks for the new patch. I had to use 'patch' to apply parts of it as 'git apply' refuses to apply only parts of a patch. The spec.file still gives some errors. patching file etc/slurmdbd.service.in patching file etc/slurmd.service.in patching file slurm.spec Hunk #1 FAILED at 93. Hunk #18 FAILED at 425. Hunk #21 FAILED at 637. 3 out of 30 hunks FAILED -- saving rejects to file slurm.spec.rej I have committed only the first 3 parts. commit d05f6994834d9a468a7f53837068f4832538297e Author: Josko Plazonic <plazonic@princeton.edu> Date: Thu Nov 5 15:12:24 2015 +0100 Improve the systemd startup files. I think this is ok for now as I need to see what Support things of the spec file patch which introduces new things like support for logrotate which is an external software not released with Slurm. David
Created attachment 2391 [details] Updated patch against git branch for 15.08 Original patch was against 15.08.3 tarball - rebased it to git. I promise to next time try doing it the right way (i.e. going through github...). As far as logrotate - it's a pretty standard thing to have... If not present it just won't do anything but any RHEL/Fedora release has it and I am pretty sure every other rpm based distro does too.
No worries. :-) Yes logrotate is pretty standard indeed, we recommended people using it, but I still have to synchronize with Support. David
For the spec file we have a opened a ticket #2061 to restructure the current rpms. We will commit your patch for the spec file under that problem. Najljepša hvala, David
Grazie, but I have no access to #2061 :(
2061 is actually empty, it it a placeholder for the rpm work. I will see if we can add you in cc since you have submitted the valuable patch. On 11/06/2015 03:07 PM, bugs@schedmd.com wrote: > > *Comment # 8 <http://bugs.schedmd.com/show_bug.cgi?id=2092#c8> on bug > 2092 <http://bugs.schedmd.com/show_bug.cgi?id=2092> from Josko > Plazonic <mailto:plazonic@princeton.edu> * > Grazie, but I have no access to #2061 :( > ------------------------------------------------------------------------ > You are receiving this mail because: > > * You are on the CC list for the bug. > * You are the assignee for the bug. > * You are watching someone on the CC list of the bug. > * You are watching the assignee of the bug. >
