Ticket 1907 - Incorrect error code in the forwarding logic
Summary: Incorrect error code in the forwarding logic
Status: RESOLVED FIXED
Alias: None
Product: Slurm
Classification: Unclassified
Component: slurmd (show other tickets)
Version: 15.08.0
Hardware: Linux Linux
: 3 - Medium Impact
Assignee: David Bigagli
QA Contact:
URL:
Depends on:
Blocks:
 
Reported: 2015-09-03 00:59 MDT by Artem Polyakov
Modified: 2015-09-06 21:11 MDT (History)
2 users (show)

See Also:
Site: -Other-
Slinky Site: ---
Alineos Sites: ---
Atos/Eviden Sites: ---
Confidential Site: ---
Coreweave sites: ---
Cray Sites: ---
DS9 clusters: ---
Google sites: ---
HPCnow Sites: ---
HPE Sites: ---
IBM Sites: ---
NOAA SIte: ---
NoveTech Sites: ---
Nvidia HWinf-CS Sites: ---
OCF Sites: ---
Recursion Pharma Sites: ---
SFW Sites: ---
SNIC sites: ---
Tzag Elita Sites: ---
Linux Distro: ---
Machine Name:
CLE Version:
Version Fixed: 15.08.1
Target Release: ---
DevPrio: ---
Emory-Cloud Sites: ---

Attachments
Set return error code correctly. (993 bytes, patch)
2015-09-03 00:59 MDT, Artem Polyakov 		Details | Diff
Update. Fix the default rc value to 0. (2.47 KB, patch)
2015-09-03 01:12 MDT, Artem Polyakov 		Details | Diff
comm_error_fix_v3.diff (1.69 KB, patch)
2015-09-03 08:59 MDT, Artem Polyakov 		Details | Diff
Show Obsolete (2) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this ticket.
Description Artem Polyakov 2015-09-03 00:59:37 MDT 
Created attachment 2175 [details]
Set return error code correctly.

I've faced the problem where running out of space because of log files. The errno that was setted in "debug" macro was influence communication which is not right.
Comment 1 Artem Polyakov 2015-09-03 01:12:25 MDT 
Created attachment 2177 [details]
Update. Fix the default rc value to 0.

Forgot to set rc to 0 by default.
Comment 2 Artem Polyakov 2015-09-03 08:59:46 MDT 
Created attachment 2183 [details]
comm_error_fix_v3.diff

Add Mellanox copyright notice, remove irrelevant text from patch
Comment 3 David Bigagli 2015-09-06 21:11:01 MDT 
commit 8fca7be426243c3def3eb6a4ab17a1184cccaa5b
Author: Artem Polyakov <artpol84@gmail.com>
Date:   Mon Sep 7 11:08:16 2015 +0200

Thanks!

David