Ticket 1745 - Change priority on held jobs return no error
Summary: Change priority on held jobs return no error
Status: RESOLVED FIXED
Alias: None
Product: Slurm
Classification: Unclassified
Component: Scheduling (show other tickets)
Version: 14.11.8
Hardware: Linux Linux
: 5 - Enhancement
Assignee: Brian Christiansen
QA Contact:
URL:
Depends on:
Blocks:
 
Reported: 2015-06-15 04:58 MDT by Thomas Cadeau
Modified: 2015-06-30 04:50 MDT (History)
3 users (show)

See Also:
Site: Atos/Eviden Sites
Slinky Site: ---
Alineos Sites: ---
Atos/Eviden Sites: ---
Confidential Site: ---
Coreweave sites: ---
Cray Sites: ---
DS9 clusters: ---
Google sites: ---
HPCnow Sites: ---
HPE Sites: ---
IBM Sites: ---
NOAA SIte: ---
NoveTech Sites: ---
Nvidia HWinf-CS Sites: ---
OCF Sites: ---
Recursion Pharma Sites: ---
SFW Sites: ---
SNIC sites: ---
Tzag Elita Sites: ---
Linux Distro: ---
Machine Name:
CLE Version:
Version Fixed: 14.11.8 15.08.0pre6
Target Release: ---
DevPrio: ---
Emory-Cloud Sites: ---


Attachments

Note You need to log in before you can comment on or make changes to this ticket.
Description Thomas Cadeau 2015-06-15 04:58:23 MDT
Using "scontrol update job=10 priority=0" set the job in JobHeldUser/JobHeldAdmin state.

But if we use "scontrol update job=10 priority=10", of course priotity is not changed, there is no error.

Then with "scontrol release job=10", we can see the priority is reset to initial one, but not to 10.

Maybe an error can printed when trying to change the priority of an held job?
Something like:

@file job_mgr.c :
info("ignore priority reset request on held job %u",
job_ptr->job_id);
+ error_code = ESLURM_JOB_HELD;

Thomas
Comment 1 Brian Christiansen 2015-06-29 09:57:21 MDT
Committed in:
https://github.com/SchedMD/slurm/commit/3f91f4b2c04526c410f94e94974192af55f2ba53
Comment 2 Thomas Cadeau 2015-06-29 21:06:19 MDT
As you used the solution I proposed, why Nathan is the author of the commit?
Comment 3 Brian Christiansen 2015-06-30 04:18:49 MDT
My mistake. It's fixed in the commit:
https://github.com/SchedMD/slurm/commit/cd86abea2fe2eb44979056964b0c00211a8b509f
Comment 4 Thomas Cadeau 2015-06-30 04:50:13 MDT
Thank you, I see it but in: 
https://github.com/SchedMD/slurm/commit/d798caa9665a188be62eac630fdee5fa3bda58c8