Ticket 17428 - Small bugs in tests 32.4 and 32.8 in test suite
Summary: Small bugs in tests 32.4 and 32.8 in test suite
Status: RESOLVED FIXED
Alias: None
Product: Slurm
Classification: Unclassified
Component: Test Suite (show other tickets)
Version: 23.02.4
Hardware: Linux Linux
: 4 - Minor Issue
Assignee: Albert Gil
QA Contact:
URL:
Depends on:
Blocks:
 
Reported: 2023-08-15 04:17 MDT by Bjørn-Helge Mevik
Modified: 2023-09-11 01:35 MDT (History)
0 users

See Also:
Site: Sigma2 Norway
Slinky Site: ---
Alineos Sites: ---
Atos/Eviden Sites: ---
Confidential Site: ---
Coreweave sites: ---
Cray Sites: ---
DS9 clusters: ---
Google sites: ---
HPCnow Sites: ---
HPE Sites: ---
IBM Sites: ---
NOAA SIte: ---
NoveTech Sites: ---
Nvidia HWinf-CS Sites: ---
OCF Sites: ---
Recursion Pharma Sites: ---
SFW Sites: ---
SNIC sites: ---
Tzag Elita Sites: ---
Linux Distro: ---
Machine Name:
CLE Version:
Version Fixed: 22.05.10 23.02.6
Target Release: ---
DevPrio: ---
Emory-Cloud Sites: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this ticket.
Description Bjørn-Helge Mevik 2023-08-15 04:17:41 MDT 
While testing 23.02.4, we came across two small errors in the test suite:

1) In testsuite/expect/test32.4, the line

set sgather_out   "{test_name}_sgather.out"

should read

set sgather_out   "${test_name}_sgather.out"

(this is just a cosmetic error - the test will work anyway).

2) In testsuite/expect/test32.8, the line

wai_for_file -fail $file_out

shoule read

wait_for_file -fail $file_out

This error makes the test fail.

Regards,
Bjørn-Helge Mevik
Comment 1 Jason Booth 2023-08-15 09:34:08 MDT 
Thanks for reporting this.
Comment 2 Albert Gil 2023-09-11 01:35:54 MDT 
Hi Bjørn-Helge,

Thanks for reporting this.
I've committed your fixes and I took the oportunity to review all test32.* to improve them.
This is all pushed:

*   021ffac80a Merge branch 'slurm-23.02'                                                
|\  
| *   792630bee7 Merge branch 'slurm-22.05' into slurm-23.02                               
| |\  
| | * 649f09d41d Testsuite - Improve test32.12 verifying that ConnectTimeout is used       
| | * c9e36a5015 Testsuite - Improve test32.9 avoiding mismatching locale time formats     
| | * a823108715 Testsuite - Improve test32.6 verifying that -C is used                    
| | * e75a2d3b57 Testsuite - Improve test32.5 using better patterns                        
| | * 5d59246c6d Testsuite - Improve test32.8 verifying fanout behavior                    
| | * 84ae55b277 Testsuite - Improve test32.4 avoiding misleading errors                   
| | * 3bfb3061c1 Testsuite - Fix typo in test32.8                                          
| | * a81984cf1c Testsuite - Fix typo in test23.4 using test_dir

Thanks,
Albert