Ticket 11160 - custom scripts are not referenced correctly in setup.py in slurm-gcp
Summary: custom scripts are not referenced correctly in setup.py in slurm-gcp
Status: RESOLVED FIXED
Alias: None
Product: Slurm
Classification: Unclassified
Component: Cloud (show other tickets)
Version: 21.08.x
Hardware: Linux Linux
: 4 - Minor Issue
Assignee: Broderick Gardner
QA Contact:
URL:
Depends on:
Blocks:
 
Reported: 2021-03-21 08:06 MDT by vjbeltrani
Modified: 2021-03-23 10:17 MDT (History)
0 users

See Also:
Site: Google
Slinky Site: ---
Alineos Sites: ---
Atos/Eviden Sites: ---
Confidential Site: ---
Coreweave sites: ---
Cray Sites: ---
DS9 clusters: ---
Google sites: ---
HPCnow Sites: ---
HPE Sites: ---
IBM Sites: ---
NOAA SIte: ---
NoveTech Sites: ---
Nvidia HWinf-CS Sites: ---
OCF Sites: ---
Recursion Pharma Sites: ---
SFW Sites: ---
SNIC sites: ---
Tzag Elita Sites: ---
Linux Distro: ---
Machine Name:
CLE Version:
Version Fixed: 20.11.5
Target Release: ---
DevPrio: ---
Emory-Cloud Sites: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this ticket.
Description vjbeltrani 2021-03-21 08:06:50 MDT 
This is for the slurm-gcp terraform scripts in the repo: https://github.com/SchedMD/slurm-gcp 

I believe the custom-* scripts are referenced incorrectly in setup.py. Instead of this:

 util.run(str(dirs.scripts/'slurm/scripts/custom-controller-install'))

I believe it should just be, for example, this:

 util.run(str(dirs.scripts/'custom-controller-install'))

Same with the references to custom-compute-install.

Without those changes, the custom-* scripts are just ignored (because of the pass in the exception block)
Comment 1 Broderick Gardner 2021-03-23 10:17:45 MDT 
The paths have been fixed in the master branch on github. Separately, I'm also adding additional error messages.

Thanks