Ticket 5792

Summary:	Build/Linker errors on FreeBSD 11.2
Product:	Slurm	Reporter:	Joseph Mingrone <jrm>
Component:	Build System and Packaging	Assignee:	Jacob Jenson <jacob>
Status:	RESOLVED DUPLICATE	QA Contact:
Severity:	6 - No support contract
Priority:	---	CC:	bacon4000, sts
Version:	18.08.0
Hardware:	Other
OS:	Other
Site:	-Other-	Alineos Sites:	---
Atos/Eviden Sites:	---	Confidential Site:	---
Coreweave sites:	---	Cray Sites:	---
DS9 clusters:	---	HPCnow Sites:	---
HPE Sites:	---	IBM Sites:	---
NOAA SIte:	---	NoveTech Sites:	---
Nvidia HWinf-CS Sites:	---	OCF Sites:	---
Recursion Pharma Sites:	---	SFW Sites:	---
SNIC sites:	---	Tzag Elita Sites:	---
Linux Distro:	---	Machine Name:
CLE Version:		Version Fixed:
Target Release:	---	DevPrio:	---
Emory-Cloud Sites:	---
Attachments:	srun_job: Fix FreeBSD build by defining environ and __environ

Description Joseph Mingrone 2018-09-29 10:50:44 MDT

Hello,

Linker errors using --with-hdf5:
libtool: link: cc -O2 -pipe -I/wrkdirs/usr/ports/sysutils/slurm-wlm/work/slurm-18.08.0/slurm -I/usr/local/include -fstack-protector -fno-strict-aliasing -D_THREAD_SAFE -pthread -ggdb3 -Wall -g -O1 -fno-strict-aliasing -fstack-protector -o sh5util sh5util.o -Wl,-rpath=/usr/local/lib/slurm -Wl,--export-dynamic  -L/usr/local/lib ../.libs/libhdf5_api.a -lsysinfo -lkvm -lm -ldl -lz -lsz -lhdf5 -lhdf5_hl -pthread
sh5util.o: In function `main':
/wrkdirs/usr/ports/sysutils/slurm-wlm/work/slurm-18.08.0/src/plugins/acct_gather_profile/hdf5/sh5util/sh5util.c:210: undefined reference to `info'
/wrkdirs/usr/ports/sysutils/slurm-wlm/work/slurm-18.08.0/src/plugins/acct_gather_profile/hdf5/sh5util/sh5util.c:230: undefined reference to `error'
/wrkdirs/usr/ports/sysutils/slurm-wlm/work/slurm-18.08.0/src/plugins/acct_gather_profile/hdf5/sh5util/sh5util.c:215: undefined reference to `info'
/wrkdirs/usr/ports/sysutils/slurm-wlm/work/slurm-18.08.0/src/plugins/acct_gather_profile/hdf5/sh5util/sh5util.c:220: undefined reference to `info'
/wrkdirs/usr/ports/sysutils/slurm-wlm/work/slurm-18.08.0/src/plugins/acct_gather_profile/hdf5/sh5util/sh5util.c:226: undefined reference to `info'
...
Full build log: http://pkg.awarnach.mathstat.dal.ca/data/11amd64-default/2018-09-29_12h05m03s/logs/errors/slurm-wlm-18.08.0.log

The build progresses further using --without-hdf5, but hits other linker errors:
libtool: link: cc -O2 -pipe -I/wrkdirs/usr/ports/sysutils/slurm-wlm/work/slurm-18.08.0/slurm -I/usr/local/include -fstack-protector -fno-strict-aliasing -D_THREAD_SAFE -pthread -ggdb3 -Wall -g -O1 -fno-strict-aliasing -fstack-protector -o sacct options.o print.o process.o sacct.o -Wl,-rpath=/usr/local/lib/slurm -Wl,--export-dynamic  -L/usr/local/lib -lsysinfo -lkvm -ldl -pthread
options.o: In function `get_data':
/wrkdirs/usr/ports/sysutils/slurm-wlm/work/slurm-18.08.0/src/sacct/options.c:567: undefined reference to `slurmdb_jobcomp_jobs_get'
/wrkdirs/usr/ports/sysutils/slurm-wlm/work/slurm-18.08.0/src/sacct/options.c:570: undefined reference to `slurmdb_jobs_get'
/wrkdirs/usr/ports/sysutils/slurm-wlm/work/slurm-18.08.0/src/sacct/options.c:585: undefined reference to `list_iterator_create'
/wrkdirs/usr/ports/sysutils/slurm-wlm/work/slurm-18.08.0/src/sacct/options.c:621: undefined reference to `slurmdb_ave_tres_usage'
...
Full build log: http://pkg.awarnach.mathstat.dal.ca/data/11amd64-default/2018-09-29_12h07m28s/logs/errors/slurm-wlm-18.08.0.log

Configuring with --without-shared-libslurm allows the build to progress further, but it then hits an 'undeclared identifier' error.
srun_job.c:1349:44: error: use of undeclared identifier '__environ'
        env_array_merge(&job->env, (const char **)__environ);
Full build log: http://pkg.awarnach.mathstat.dal.ca/data/11amd64-default/2018-09-29_12h09m40s/logs/errors/slurm-wlm-18.08.0.log

Sorry I can't offer patches.  I tried, but had no luck.  If there is anything I can test, please let me know.

Comment 1 Joseph Mingrone 2018-09-30 00:18:03 MDT

Created attachment 7918 [details]
srun_job: Fix FreeBSD build by defining environ and __environ

1. glibc has `extern char **environ;` in <unistd.h>, but hidden behind `#ifdef
__USE_GNU`.  Since libc has the `environ` symbol defined, simply defining it
here should work.  Guard it behind #ifdef __FreeBSD__ to ensure this does not
cause problems elsewhere.

2. #define __environ environ

While this fixes the build, I am not familiar enough to do sufficient run-time tests.  If there are specific tests you recommend, just let me know.

Comment 2 Jason Bacon 2020-04-03 18:47:47 MDT

This patch is included in bug 8602 along with several others.

*** This ticket has been marked as a duplicate of ticket 8602 ***