Ticket 4805

Summary:	FreeBSD build error, no roken.h file
Product:	Slurm	Reporter:	Moe Jette <jette>
Component:	Build System and Packaging	Assignee:	Tim Wickberg <tim>
Status:	RESOLVED FIXED	QA Contact:
Severity:	4 - Minor Issue
Priority:	---	CC:	jrm
Version:	17.11.3
Hardware:	Linux
OS:	Linux
Site:	SchedMD	Alineos Sites:	---
Atos/Eviden Sites:	---	Confidential Site:	---
Coreweave sites:	---	Cray Sites:	---
DS9 clusters:	---	HPCnow Sites:	---
HPE Sites:	---	IBM Sites:	---
NOAA SIte:	---	OCF Sites:	---
Recursion Pharma Sites:	---	SFW Sites:	---
SNIC sites:	---	Linux Distro:	---
Machine Name:		CLE Version:
Version Fixed:	17.11.4 18.08.0-pre2	Target Release:	---
DevPrio:	---	Emory-Cloud Sites:	---
Attachments:	Do not include rtoken.h on FreeBSD

Description Moe Jette 2018-02-19 11:12:47 MST

A bug report was submitted for the FreeBSD slurm package claiming that the roken.h header is not needed and causes problems when WITHOUT_KERBEROS is used.  After a bit of grepping I do not see why it is required.  What do you say?  Should '#include <roken.h>' be dropped from src/plugins/mpi/pmi2/agent.c, src/plugins/mpi/pmi2/agent.c, and src/plugins/mpi/pmi2/pmi2.c?

Joseph Mingrone <jrm@ftfl.ca>

Comment 4 Tim Wickberg 2018-02-27 08:16:45 MST

Joseph - 

I added you on as CC so you'd see this. I push this fix to strip those headers out, it doesn't look like they've been required for quite some time now:

commit c6330552bfddf924cd0b466dbd014dfb566b71fb
Author: Tim Wickberg <tim@schedmd.com>
Date:   Tue Feb 27 08:13:50 2018 -0700

    Remove <roken.h> header include from FreeBSD builds.
    
    No longer needed, and will cause errors on FreeBSD systems
    build with WITHOUT_KERBEROS.
    
    Bug 4805.

Comment 5 Joseph Mingrone 2018-02-27 08:19:40 MST

Created attachment 6241 [details]
Do not include rtoken.h on FreeBSD

Comment 6 Joseph Mingrone 2018-02-27 08:20:58 MST

Hi Tim.

The FreeBSD port/package has been running with the attached patch for about a week and so far, I have not received any reports.

Thanks,

Joseph