Ticket 9606

We are running 19.05 with https://bugs.schedmd.com/attachment.cgi?id=13854 from https://bugs.schedmd.com/show_bug.cgi?id=8584. We did not yet pull in the commit that Brian recommended, but I'm not sure if lack of that would cause this problem.

We have seen 2 segfaults with backtraces like:

Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x0000000000440091 in _remove_job_hash (job_entry=job_entry@entry=0x7f6a40000c00, type=type@entry=JOB_HASH_JOB) at job_mgr.c:2940
2940            while ((job_pptr != NULL) && (*job_pptr != NULL) &&
[Current thread is 1 (Thread 0x7f6a7cd54b80 (LWP 6670))]
Missing separate debuginfos, use: zypper install slurm-slurmctld-debuginfo-19.05.5-1.x86_64
(gdb) bt
#0  0x0000000000440091 in _remove_job_hash (job_entry=job_entry@entry=0x7f6a40000c00, type=type@entry=JOB_HASH_JOB) at job_mgr.c:2940
#1  0x000000000044216d in _delete_job_common (job_ptr=0x7f6a40000c00) at job_mgr.c:9343
#2  0x0000000000456371 in _list_delete_job (job_entry=<optimized out>) at job_mgr.c:9366
#3  0x00007f6a7c7fe1c7 in list_delete_all (l=0x6f82c0, f=f@entry=0x446d1a <_list_find_job_old>, key=key@entry=0x4c6acd) at list.c:420
#4  0x000000000044f1eb in purge_old_job () at job_mgr.c:10935
#5  0x0000000000431aa5 in _slurmctld_background (no_data=0x0) at controller.c:2162
#6  main (argc=<optimized out>, argv=<optimized out>) at controller.c:762
(gdb) p job_pptr
$1 = (struct job_record **) 0x3757724871417987

In the other backtrace;
(gdb) p job_pptr
$1 = (struct job_record **) 0x2400000174

Those pointers are invalid, as they cannot be de-referenced.