Ticket 9417

Summary:	AcctGatherEnergyType=acct_gather_energy/cray_aries missing from slurm.conf manpage/web
Product:	Slurm	Reporter:	Andrew Elwell <Andrew.Elwell>
Component:	Documentation	Assignee:	Ben Roberts <ben>
Status:	RESOLVED FIXED	QA Contact:
Severity:	3 - Medium Impact
Priority:	---	CC:	felip.moll
Version:	20.02.2
Hardware:	Linux
OS:	Linux
Site:	Pawsey	Slinky Site:	---
Alineos Sites:	---	Atos/Eviden Sites:	---
Confidential Site:	---	Coreweave sites:	---
Cray Sites:	---	DS9 clusters:	---
Google sites:	---	HPCnow Sites:	---
HPE Sites:	---	IBM Sites:	---
NOAA SIte:	---	NoveTech Sites:	---
Nvidia HWinf-CS Sites:	---	OCF Sites:	---
Recursion Pharma Sites:	---	SFW Sites:	---
SNIC sites:	---	Tzag Elita Sites:	---
Linux Distro:	---	Machine Name:
CLE Version:		Version Fixed:	20.11.0pre1
Target Release:	---	DevPrio:	---
Emory-Cloud Sites:	---

Description Andrew Elwell 2020-07-19 05:40:54 MDT

I've just noticed that the slurm.conf webpage https://slurm.schedmd.com/slurm.conf.html doesn't list acct_gather_energy/cray_aries in the valid types for AcctGatherEnergyType
despite it existing at https://github.com/SchedMD/slurm/tree/master/src/plugins/acct_gather_energy/cray_aries

please can this be corrected?

Comment 1 Andrew Elwell 2020-07-19 05:43:58 MDT

Also noticed it's missing from https://slurm.schedmd.com/acct_gather_energy_plugins.html

Comment 4 Ben Roberts 2020-07-20 15:34:06 MDT

Hi Andrew,

Thank you for bringing this to our attention.  I have put together a patch to add a note about the cray_aries AcctGatherEnergyType in the two places you mentioned along with a note in the Cray page we have.  The patch will undergo an internal review and I'll let you know when it has been checked in.

Thanks,
Ben

Comment 6 Ben Roberts 2020-08-20 16:09:32 MDT

Hi Andrew,

The changes to the documentation have been checked in for this, though there are some caveats.  A change to the plugin name was committed for 20.11 that renames it from cray_aries to pm_counters.  You can see details of that change in this commit:
commit 9fa00eec067372150427631b1a21d405905e4f61
Author: Tim Wickberg <tim@schedmd.com>
Date:   Thu Aug 20 15:24:42 2020 -0600

    Rename acct_gather_energy/cray_aries to acct_gather_energy/pm_counters.
    
    Bug 7575.


Since that is the case, the documentation patch has been updated to reflect the new name (pm_counters) and has only been checked in for 20.11.  You will see this in the documentation on our website when 20.11 is released in November.  The commit for the documentation change is:
commit 60e993dd9d68b3d88a6953db4785d2d9aa140e82
Author: Ben Roberts <ben@schedmd.com>
Date:   Mon Jul 20 15:56:22 2020 -0500

    Docs - add info about the acct_gather_energy/pm_counters plugin.
    
    Bug 9417.


I'm closing this ticket, but let me know if you have any questions.

Thanks,
Ben