Ticket 6660

Summary:	18.08.6 spec fails to include accounting_storage_mysql.so in slurm-slurmdbd RPM
Product:	Slurm	Reporter:	Kilian Cavalotti <kilian>
Component:	Build System and Packaging	Assignee:	Tim Wickberg <tim>
Status:	RESOLVED FIXED	QA Contact:
Severity:	3 - Medium Impact
Priority:	---	CC:	nate
Version:	18.08.5
Hardware:	Linux
OS:	Linux
See Also:	https://bugs.schedmd.com/show_bug.cgi?id=6511
Site:	Stanford	Alineos Sites:	---
Atos/Eviden Sites:	---	Confidential Site:	---
Coreweave sites:	---	Cray Sites:	---
DS9 clusters:	---	HPCnow Sites:	---
HPE Sites:	---	IBM Sites:	---
NOAA SIte:	---	OCF Sites:	---
Recursion Pharma Sites:	---	SFW Sites:	---
SNIC sites:	---	Linux Distro:	---
Machine Name:	Sherlock	CLE Version:
Version Fixed:	18.08.6-2 19.05.0pre3	Target Release:	---
DevPrio:	---	Emory-Cloud Sites:	---

Description Kilian Cavalotti 2019-03-07 15:35:03 MST

Hi, 

It looks like the freshly released 18.08.6 spec file does not automatically include accounting_storage_mysql.so in the slurm-slurmdbd RPM anymore.

I get it's a consequence of https://bugs.schedmd.com/show_bug.cgi?id=6488, but it doesn't seem to work as expected: when MySQL headers are available on the build host, MySQL support is still automatically detected by the configure script, and the accounting_storage_mysql.so is still built. But now, it's not packaged in the RPM anymore. 

This will lead to a number of headaches at sites that rely on default detection of MySQL and don't expect to have to change their rpmbuild command to continue using it.

Plus, "--with mysql" seems to be on by default in the spec file, so that's quite counter-intuitive.

Here's what we tried:

$ rpmbuild -ta slurm-18.08.6.tar.bz2
[...]

The accounting_storage_mysql.so lib is built:

$ cd ~/rpmbuild/BUILD/slurm-18.08.6/
$ find ./ -name accounting_storage_mysql.so
./src/plugins/accounting_storage/mysql/.libs/accounting_storage_mysql.so

But it's not added to the RPM:

$ rpm -qlp ~/rpmbuild/RPMS/x86_64/slurm-slurmdbd-18.08.6-1.el7.x86_64.rpm
/usr/lib/systemd/system/slurmdbd.service
/usr/sbin/slurmdbd


It works when doing "rpmbuild --with mysql -ta slurm-18.08.6.tar.bz2", but this is a breaking change.

Cheers,
-- 
Kilian

Comment 1 Tim Wickberg 2019-03-07 15:52:50 MST

Sorry about that, and thank you for the quick troubleshooting. I've pushed a new 18.08.6-2 with that offending commit removed now.

- Tim

Comment 2 Kilian Cavalotti 2019-03-07 15:57:14 MST

Hi Tim. 

Thanks for the lightning-fast fix, much appreciated!

Cheers,
--
Kilian