Ticket 341

Summary:	on ipmi plugin, option ajustment is not really used
Product:	Slurm	Reporter:	Thomas Cadeau <thomas.cadeau>
Component:	Accounting	Assignee:	Danny Auble <da>
Status:	RESOLVED FIXED	QA Contact:
Severity:	3 - Medium Impact
Priority:	---
Version:	2.6.x
Hardware:	Linux
OS:	Linux
Site:	Atos/Eviden Sites	Alineos Sites:	---
Atos/Eviden Sites:	---	Confidential Site:	---
Coreweave sites:	---	Cray Sites:	---
DS9 clusters:	---	HPCnow Sites:	---
HPE Sites:	---	IBM Sites:	---
NOAA SIte:	---	OCF Sites:	---
Recursion Pharma Sites:	---	SFW Sites:	---
SNIC sites:	---	Linux Distro:	---
Machine Name:		CLE Version:
Version Fixed:		Target Release:	---
DevPrio:	---	Emory-Cloud Sites:	---
Attachments:	patch for adjustment option on ipmi plugin patch for adjustment option on ipmi plugin (without previous error)

Description Thomas Cadeau 2013-06-20 02:39:21 MDT

Created attachment 303 [details]
patch for adjustment option on ipmi plugin

Hello,


For jobs/steps, adjustment option allow to estimate the consumption using:
- last computed consumption
- last mesured watt
- time of last mesured/computed values
- time of "real" begin and end of job/step (time(null) in the function)

Current code use:
- last computed consumption
- last mesured watt
- time of "real" end of job/step (time(null) before communication of values)
- time of "real" end of job/step (time(null) after communication of values)


The patch change this, using local_energy->poll_time, and adjust also local_energy->consumed_energy when steps start.

Comment 1 Thomas Cadeau 2013-06-20 02:44:53 MDT

Created attachment 304 [details]
patch for adjustment option on ipmi plugin (without previous error)

Comment 2 Danny Auble 2013-06-25 06:00:02 MDT

Thanks Thomas, I moved this adjustment outside of the if statement to avoid potential future issues with duplicate code.  Your code is in 58e87d46274c1030cf8ddb370ef743ae21a47660 and what I did is in 2d1841dbfc931444879f48c5f155e63e271ff03d.

Reopen the ticket if you see any errors or don't like what I did.