| Summary: | squeue --licenses constraints match too many jobs | ||
|---|---|---|---|
| Product: | Slurm | Reporter: | Doug Jacobsen <dmjacobsen> |
| Component: | User Commands | Assignee: | Alejandro Sanchez <alex> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | 4 - Minor Issue | ||
| Priority: | --- | CC: | alex |
| Version: | 16.05.4 | ||
| Hardware: | Cray XC | ||
| OS: | Linux | ||
| Site: | NERSC | Alineos Sites: | --- |
| Atos/Eviden Sites: | --- | Confidential Site: | --- |
| Coreweave sites: | --- | Cray Sites: | --- |
| DS9 clusters: | --- | HPCnow Sites: | --- |
| HPE Sites: | --- | IBM Sites: | --- |
| NOAA SIte: | --- | OCF Sites: | --- |
| Recursion Pharma Sites: | --- | SFW Sites: | --- |
| SNIC sites: | --- | Linux Distro: | --- |
| Machine Name: | CLE Version: | ||
| Version Fixed: | 16.05.5 17.02 | Target Release: | --- |
| DevPrio: | --- | Emory-Cloud Sites: | --- |
|
Description
Doug Jacobsen
2016-09-07 11:15:08 MDT
Hi Doug, we're looking into this and will come back to you. I can reproduce this problem, working on a fix now. Most probably it's a wrong substring compare. Hi Doug. Following patch should solve the filtering issues on licenses: https://github.com/SchedMD/slurm/commit/1ec2a4ae07357d It will be included in 16.05.5. If it's an urge for you, please apply it before the release date and let me know if we can close the ticket or if you find any issue. Otherwise, I'll mark the ticket as resolved/fixed. Doug, please do not apply the patch yet, we think it'd fail if job requested more than 1 license, for instance scratch1:2 since xstrcmp tries to matches the exact token (avoiding cscratch1 to match too for being a substring) but then would fail with scratch1:2, so gonna ammend this patch. Will come back to you. Yeah, sorry, I was reviewing and was going to suggest a variant of strncmp with the colon delimiter. Thanks for continuing to look at this, Doug ---- Doug Jacobsen, Ph.D. NERSC Computer Systems Engineer National Energy Research Scientific Computing Center <http://www.nersc.gov> dmjacobsen@lbl.gov ------------- __o ---------- _ '\<,_ ----------(_)/ (_)__________________________ On Fri, Sep 9, 2016 at 8:15 AM, <bugs@schedmd.com> wrote: > *Comment # 13 <https://bugs.schedmd.com/show_bug.cgi?id=3063#c13> on bug > 3063 <https://bugs.schedmd.com/show_bug.cgi?id=3063> from Alejandro Sanchez > <alex@schedmd.com> * > > Doug, please do not apply the patch yet, we think it'd fail if job requested > more than 1 license, for instance scratch1:2 since xstrcmp tries to matches the > exact token (avoiding cscratch1 to match too for being a substring) but then > would fail with scratch1:2, so gonna ammend this patch. Will come back to you. > > ------------------------------ > You are receiving this mail because: > > - You reported the bug. > > Doug, following commit should fix this bug (included in Slurm 16.05.5): https://github.com/SchedMD/slurm/commit/cbd1ffadd5492 Please, let me know if we can close the ticket. Doug - can we close this bug? Thanks. Closing as resolved/fixed. Please reopen if you encounter further issues. Great, thank you! On 10/20/16 2:00 AM, bugs@schedmd.com wrote: > Alejandro Sanchez <mailto:alex@schedmd.com> changed bug 3063 > <https://bugs.schedmd.com/show_bug.cgi?id=3063> > What Removed Added > Resolution --- FIXED > Version Fixed 16.05.5 17.02 > Status CONFIRMED RESOLVED > > *Comment # 22 <https://bugs.schedmd.com/show_bug.cgi?id=3063#c22> on > bug 3063 <https://bugs.schedmd.com/show_bug.cgi?id=3063> from > Alejandro Sanchez <mailto:alex@schedmd.com> * > Closing as resolved/fixed. Please reopen if you encounter further issues. > ------------------------------------------------------------------------ > You are receiving this mail because: > > * You reported the bug. > |