Ticket 10855

Hey Matt -

Adding a 'Comment' field sounds reasonable.

Is this something you're looking to submit as a patch at some point, or something you're considering sponsoring?

- Tim

(In reply to Tim Wickberg from comment #1)
> Adding a 'Comment' field sounds reasonable.
> 
> Is this something you're looking to submit as a patch at some point, or
> something you're considering sponsoring?

Do you think the comment needs to be stored in the database, or just in slurmctld If just slurmctld, I can probably put together a patch pretty easily. I'm not familiar with the database code, so if I need to touch that it will take longer OR need to be sponsored.

(In reply to Matt Ezell from comment #2)
> (In reply to Tim Wickberg from comment #1)
> > Adding a 'Comment' field sounds reasonable.
> > 
> > Is this something you're looking to submit as a patch at some point, or
> > something you're considering sponsoring?
> 
> Do you think the comment needs to be stored in the database, or just in
> slurmctld If just slurmctld, I can probably put together a patch pretty
> easily. I'm not familiar with the database code, so if I need to touch that
> it will take longer OR need to be sponsored.

It should end up in the database alongside the other comment types. Even if you don't need it there, someone will want it, and I won't be able to accept a patch that doesn't cover that obvious use case.

Created attachment 17943 [details]
patch_v1

[root@ezy-vm ~]# scontrol show res
No reservations in the system
[root@ezy-vm ~]# scontrol create res=kale start=now duration=10:00 user=root nodes=ALL comment="test1"
Reservation created: kale
[root@ezy-vm ~]# scontrol show res
ReservationName=kale StartTime=2021-02-15T20:12:37 EndTime=2021-02-15T20:22:37 Duration=00:10:00
   Nodes=ezy-vm NodeCnt=1 CoreCnt=2 Features=(null) PartitionName=(null) Flags=SPEC_NODES,ALL_NODES
   TRES=cpu=2
   Users=root Groups=(null) Accounts=(null) Licenses=(null) State=ACTIVE BurstBuffer=(null) Watts=n/a
   MaxStartDelay=(null) Comment=test1

[root@ezy-vm ~]# scontrol update res=kale comment="test 2"
Reservation updated.
[root@ezy-vm ~]# scontrol show res
ReservationName=kale StartTime=2021-02-15T20:12:37 EndTime=2021-02-15T20:22:37 Duration=00:10:00
   Nodes=ezy-vm NodeCnt=1 CoreCnt=2 Features=(null) PartitionName=(null) Flags=SPEC_NODES,ALL_NODES
   TRES=cpu=2
   Users=root Groups=(null) Accounts=(null) Licenses=(null) State=ACTIVE BurstBuffer=(null) Watts=n/a
   MaxStartDelay=(null) Comment=test 2

[root@ezy-vm ~]# sacctmgr show reservation |grep kale
   cluster            kale                          cpu=2 2021-02-15T20:12:37 2021-02-15T20:12:58   0.000000                test1 
   cluster            kale                          cpu=2 2021-02-15T20:12:58 2021-02-15T20:22:37   0.000000               test 2 
[root@ezy-vm ~]# echo -e "GET /slurm/v0.0.37/reservations HTTP/1.1\r\n" | slurmrestd -a rest_auth/local
slurmrestd: operations_router: [fd:0->/dev/pts/8] GET /slurm/v0.0.37/reservations
slurmrestd: rest_auth/local: slurm_rest_auth_p_authenticate: slurm_rest_auth_p_authenticate: [fd:0->/dev/pts/8] accepted connection from uid:0
slurmrestd: rest_auth/local: slurm_rest_auth_p_apply: apply local auth for user root
HTTP/1.1 200 OK
Content-Length: 861
Content-Type: application/json

{
   "meta": {
     "plugin": {
       "type": "openapi\/v0.0.37",
       "name": "REST v0.0.37"
     },
     "Slurm": {
       "version": {
         "major": 21,
         "micro": 0,
         "minor": 8
       },
       "release": "21.08.0-0pre1"
     }
   },
   "errors": [
   ],
   "reservations": [
     {
       "flags": [
         "SPEC_NODES",
         "ALL_NODES"
       ],
       "accounts": "",
       "burst_buffer": "",
       "comment": "test 2",
       "core_count": 2,
       "core_spec_cnt": 0,
       "end_time": 1613438557,
       "features": "",
       "groups": "",
       "licenses": "",
       "max_start_delay": 0,
       "name": "kale",
       "node_count": 1,
       "node_list": "ezy-vm",
       "partition": "",
       "start_time": 1613437957,
       "watts": 4294967294,
       "tres": "cpu=2",
       "users": "root"
     }
   ]
 }

Will this be reviewed in time for 21.08? I'm not sure if it even applies cleanly anymore...

Comment on attachment 17943 [details]
patch_v1

A slightly modified version of this was added to the master branch commits 86db23a704..1bde461f94.

Thanks!

Please reopen if needed.