Ticket 8035

Summary:	sbatch --workdir option dropped without warning
Product:	Slurm	Reporter:	b1airo <blair.bethwaite>
Component:	User Commands	Assignee:	Tim Wickberg <tim>
Status:	RESOLVED FIXED	QA Contact:
Severity:	C - Contributions
Priority:	---
Version:	19.05.0
Hardware:	Linux
OS:	Linux
Site:	-Other-	Alineos Sites:	---
Atos/Eviden Sites:	---	Confidential Site:	---
Coreweave sites:	---	Cray Sites:	---
DS9 clusters:	---	HPCnow Sites:	---
HPE Sites:	---	IBM Sites:	---
NOAA SIte:	---	OCF Sites:	---
Recursion Pharma Sites:	---	SFW Sites:	---
SNIC sites:	---	Linux Distro:	---
Machine Name:		CLE Version:
Version Fixed:	19.05.4	Target Release:	---
DevPrio:	---	Emory-Cloud Sites:	---
Attachments:	patch adding NEWS re. --workdir going away

Description b1airo 2019-11-01 03:16:58 MDT

Created attachment 12197 [details]
patch adding NEWS re. --workdir going away

The --workdir option was changed to --chdir in 17.11 (though not clear what the rational for changing it was..?), however the actual option was still valid and accepted by sbatch without any warning right up until 19.05.0-rc1 where it was pulled by https://github.com/SchedMD/slurm/commit/9118a41e13c2dfb347c19b607bcce91dae70f8c6. Given it was not properly deprecated in 17.11 it seems reasonable to at least call this behaviour change out in the NEWS file. Hence the attached patch.

Comment 1 Tim Wickberg 2019-11-01 08:23:18 MDT

Hi -

Although this isn't documented well in CONTRIBUTING.md, the NEWS file is not meant to be changed retroactively once a given release is tagged.

As a concession that this particular flag was not well, I've added an entry to RELEASE_NOTES (which we do try to avoid changing as well, but at least is more likely to be read prior to a system upgrade than individual NEWS lines) covering this. Commit details follow below.

- Tim

commit 12a27b1a9600e62b138b5a8cbe756d5fd2a4e28b (HEAD -> slurm-19.05, origin/slurm-19.05)
Author:     Tim Wickberg <tim@schedmd.com>
AuthorDate: Fri Nov 1 08:21:20 2019 -0600

    RELEASE_NOTES - mention cli argument cleanup work done for 19.05.
    
    Bug 8035.

diff --git a/RELEASE_NOTES b/RELEASE_NOTES
index a390a9022f..d7c18dbcc8 100644
--- a/RELEASE_NOTES
+++ b/RELEASE_NOTES
@@ -135,6 +135,10 @@ HIGHLIGHTS
  -- Allocate nodes that are booting. Previously, nodes that were being booted
     were off limits for allocation. This caused more nodes to be booted than
     needed in a cloud environment.
+ -- Overhauled the salloc, sbatch, and srun command-line argument processing
+    code in support of the new cli_filter API. As part of this cleanup, some
+    older deprecated option forms have been removed, such as --mem_bind,
+    --share, and --workdir.